fix(types): Object.freeze type pollution from @sentry-internal/replay
#5408
+140
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
Author
|
@sentry review |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| @@ -0,0 +1,104 @@ | |||
| /** | |||
There was a problem hiding this comment.
The test file location at packages/core/test/typings/object-freeze.test.ts may not be picked up by Jest's testPathIgnorePatterns in jest.config.js, which currently ignores <rootDir>/test/typings/ directory (note the different directory structure). Verify that this test file is actually executed by the test suite. If the intent is to have type-checking tests ignored from runtime testing, consider either updating the Jest configuration or moving the test to a location that matches the configured patterns.
Severity: MEDIUM
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/core/test/typings/object-freeze.test.ts#L1
Potential issue: The test file location at
`packages/core/test/typings/object-freeze.test.ts` may not be picked up by Jest's
`testPathIgnorePatterns` in `jest.config.js`, which currently ignores
`<rootDir>/test/typings/` directory (note the different directory structure). Verify
that this test file is actually executed by the test suite. If the intent is to have
type-checking tests ignored from runtime testing, consider either updating the Jest
configuration or moving the test to a location that matches the configured patterns.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 3552648
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Fixes
Object.freezetype pollution from@sentry-internal/replay💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps